B2B login - update template code to use CMS-controlled login page #22
+1,080
−571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlweb
requested changes
Mar 18, 2025
| <div class="b2b-form"> | ||
|
|
||
|
|
||
| {% if section.settings.login_type == 'passwordless' %} |
There was a problem hiding this comment.
This shouldn't need a section setting - we can access this directly, I feel Cam used it in his template
There was a problem hiding this comment.
Sadly it never worked, all our Dawn Theme installs just show the button! As far as I can tell (and I may be wrong), you can't access this in liquid
There was a problem hiding this comment.
@cm-sl ah, try this {%- if shop.features.login_with_shop_classic_customer_accounts? -%}
There was a problem hiding this comment.
Doesn't work sadly, any other ideas?
Yeah, it's a fair point. It's going to be a trade off of being able to use the Customizer to make edits vs the Shopify translation (language string) feature. You lose the visual component which is the main attraction of using the Customizer! May be a silly question, when Shopify themes are so reliant on the Customizer, how are they handling multi-lang? Right now, this new setup will allow Market-base translations (which in theory have langauges set, see video)
|
Totally get its easier for some of the strings which are custom to the store but there's standard strings we can use for the "email" and "password" fields. If we're working for built with Shopify multi-language is key |
@rlweb There aren't standard strings though in Shopify... it varies by theme and whatever the theme developer decides! Here are two examples, both are 'Login' but use different variables 
Also highlighted by this change where we added a lang string for Dawn, but didn't work for anything else! 
Basically... I don't think there's a way to do this. It seems a lot of stores just use the translate and adapt app to do this magically. |
We're crossing paths here, but my suggestion is that this repo (for when clients use our installed dawn) uses the translations baked in for every language, meaning out of the box it works for the 20 languages supported by Dawn. For other themes, we can link to these files as a gist in the manor they work here which yes means its easier as we can't guarantee the strings match. Thoughts? |
|
@rlweb Fixed! So for the login form, this is using standard Shopify-theme (e.g. Dawn) language strings The rest of the page is CMS controlled |
AndriusBartulis
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the modified B2B login page here
This removes the old version that was hard-coded languages, bad CSS, etc
HELP DOCS need updating once merged as it changes the URL from trade-login to b2b-login ('trade-login' was a legacy from Robert Welch, it's not actually a familiar term with most users)